Fix unsafe recommended calver release expression#3231
Merged
Conversation
hnrkndrssn
approved these changes
Jul 3, 2026
|
Pull request environment is available at https://stoctodocspr3231.z22.web.core.windows.net. You can view the ephemeral environment status in Octopus Deploy. This environment will be automatically deprovisioned when the pull request is closed, or after 7 days of inactivity. |
wlthomson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the example complex release expression and adds a warning callout to signpost users towards using the alternative mask-based expression for generating calver release versions.
The removed expression (
#{if Octopus.Date.Day==Octopus.Version.LastPatch}...) behaves unexpectedly when comparisons include single-digit days and months. This is due to formatting differences betweenOctopus.Date.Day/MonthandOctopus.Version.LastPatch/LastMinor, with the former being zero-padded and the latter not. This causes the equality check to always fail when matching against dates containing single-digit days or months, causing releases to collide on the same version number instead of incrementing. This has been reported by multiple customers and replicated internally.